Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing collection errors in pytest-html v4 #755

Closed
akhilramkee opened this issue Oct 31, 2023 · 3 comments · Fixed by #756
Closed

Missing collection errors in pytest-html v4 #755

akhilramkee opened this issue Oct 31, 2023 · 3 comments · Fixed by #756

Comments

@akhilramkee
Copy link

Thanks for the rewrite and a revamped report in the pytest-html!

I noticed that the collection errors are not reported as part of pytest-html v4 but they were reported till pytest-html==3.2.0

Reproducer:

test_sample.py

import pytest

raise ImportError("Non existent module")

Run:

pytest test_sample.py --html=~/tmp/generated_html.html

pytest-html == 3.2.0:

image

pytest-html == 4.0.3rc0:

image


Looking at the codebase, I can see that pytest_collectreport got missed out during the rewrite, so maybe adding that back should fix this.

@akhilramkee
Copy link
Author

One more for pytest-html 4.0.3 :) - @BeyondEvil

@BeyondEvil
Copy link
Contributor

Oh, nice! We had indeed missed that.

Thanks for bringing it up!

@BeyondEvil
Copy link
Contributor

BeyondEvil commented Nov 1, 2023

Mind checking the PR @akhilramkee ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants