Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally specify which attributes to return in model.conduits() ? #36

Closed
aerispaha opened this issue Oct 17, 2018 · 0 comments · Fixed by #78
Closed

Optionally specify which attributes to return in model.conduits() ? #36

aerispaha opened this issue Oct 17, 2018 · 0 comments · Fixed by #78
Labels
complete enhancement
Milestone
v0.4.0

Comments

@aerispaha
Copy link
Member

aerispaha commented Oct 17, 2018 •
edited
Loading

Would it be cleaner to return model elements with only the attributes requested by the user, or should we continue to include as much related information as possible in the conduits() dataframe?
@aerispaha aerispaha added this to the v0.4.0 milestone Oct 17, 2018
@aerispaha aerispaha changed the title Optionally specify which attributes to return in model.conduits() ? Optionally specify which attributes to return in model.conduits() ? Oct 17, 2018
@aerispaha aerispaha mentioned this issue Oct 23, 2018
Closed
@aerispaha aerispaha mentioned this issue Sep 9, 2019
Open
@aerispaha aerispaha mentioned this issue Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complete enhancement
Projects
None yet
Milestone
v0.4.0
Development

Successfully merging a pull request may close this issue.

api improvements, merge models, geojson, geodataframe representations pyswmm/swmmio
1 participant
@aerispaha