Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change imports from spreg #22

Closed
ljwolf opened this issue Jul 19, 2018 · 5 comments
Closed

change imports from spreg #22

ljwolf opened this issue Jul 19, 2018 · 5 comments

Comments

@ljwolf
Copy link
Member

ljwolf commented Jul 19, 2018

We're having some trouble with a few imports here.

If it's possible, can you switch from import spreg.user_output as USER to from spreg import user_output as USER? For some reason we're not sure of, our build chokes when we have imports of the general pattern:
import package.module_name as module_alias
instead of
from package import module_name as module_alias

We need to change this in the submodule contract, but it'll be present in future releases.

@TaylorOshan
Copy link
Collaborator

This only applies to spreg dependencies, or needs to be changed throughout? @ljwolf

@ljwolf
Copy link
Member Author

ljwolf commented Jul 23, 2018

This needs to be done everywhere, but I think the only place you do it is in this spreg call.

I appreciate the change; we're trying to cut down on the size of some powerful sed black magic used in the build script.

@TaylorOshan
Copy link
Collaborator

I see, so it only applies to from package import module_name as module_alias and not to from package.module_name import class, which I do quite frequently?

@ljwolf
Copy link
Member Author

ljwolf commented Jul 23, 2018

No; it seems to only choke on:

import spreg.user_ouput as USER

but doesn't choke on

from spreg import user_output as USER

or

from spreg.user_output import check_X

@TaylorOshan
Copy link
Collaborator

Ok, then I think #24 satisfies this. Will merge and close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants