Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework pickles in the tests #21

Closed
ljwolf opened this issue Jul 18, 2018 · 3 comments
Closed

rework pickles in the tests #21

ljwolf opened this issue Jul 18, 2018 · 3 comments

Comments

@ljwolf
Copy link
Member

ljwolf commented Jul 18, 2018

if we can, we need to avoid using pickles in the tests if this is going to be distributed by pysal.

Serialize the parameters we need.

@ljwolf
Copy link
Member Author

ljwolf commented Jul 18, 2018

Or, write a script we can run to regenerate the pickles as part of pysal.model.mgwr rather than gwr.

@ljwolf ljwolf closed this as completed Jul 18, 2018
@ljwolf ljwolf reopened this Jul 18, 2018
@ljwolf ljwolf changed the title avoid pickles in the tests rework pickles in the tests Jul 18, 2018
@TaylorOshan
Copy link
Collaborator

This is solved by #23? @ljwolf

@ljwolf
Copy link
Member Author

ljwolf commented Jul 23, 2018

yes, thanks for merging 😄 👍

@ljwolf ljwolf closed this as completed Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants