Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require to re-authenticate any time "important" or "destructive" actions are performed #8139

Closed
callmecampos opened this issue Jun 19, 2020 · 1 comment
Labels
feature request needs discussion a product management/policy issue maintainers and users should discuss

Comments

@callmecampos
Copy link
Contributor

callmecampos commented Jun 19, 2020

What's the problem this feature will solve?
"Important" and "destructive" actions like adding and removing maintainers, generating API tokens, and changing passwords don't require the user to re-authenticate. This can be a risk for scenarios where users who are not the original intended user gain access to a browser with session auth cookies on them (e.g. cookie dropped on a public library computer, intended user leaves and forgets to explicitly log out, another user sits down and is already logged in). There's not much we can do to get around that outside of warning the user that they should be on a private computer when logging into PyPI.org.

Describe the solution you'd like
We should gate "important" or "destructive" actions with a re-authentication page if the user hasn't authenticated recently (say in the last 10-15 minutes). This includes:

  1. Changing passwords
  2. Changing email address or other contact information (this includes adding and removing emails)
  3. Deleting distributions
  4. Adding/removing maintainers
  5. Generating API tokens
  6. Setting up 2FA (whether with an application or a security device)

Additional context
Several major services (e.g. GitHub, Bitbucket) implement this, so we should as well. Also, the feature request in #8033, which would allow for ~30 day authenticated sessions, is further motivation for gating these actions.

@brainwane brainwane added the needs discussion a product management/policy issue maintainers and users should discuss label Jun 29, 2020
@di
Copy link
Member

di commented Aug 3, 2020

Closed by #8191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request needs discussion a product management/policy issue maintainers and users should discuss
Projects
None yet
Development

No branches or pull requests

3 participants