Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_tagopy.test_plat_name_ext and setting plat-name on non-pure wheels #374

Closed
mattip opened this issue Aug 26, 2020 · 4 comments
Closed

Comments

@mattip
Copy link
Contributor

mattip commented Aug 26, 2020

As fallout from #346, there was a change in behavior. Previously, a user could specify a plat-name and bdist_wheel would create a binary wheel with that plat-name. This is tested for in test_plat_name_ext. Before that PR the test passed, after it the test is skipped (the failed assert in get_tag is misinterpreted as an inability to compile).

Arguably, the previous behavior was unintentional intended but questionable since

  • there is a comment that only pure wheels should be allowed to specify plat-name
  • it is not clear how pip would install such a wheel
  • there is a test to make sure it is possible.

As @carljm points out in this comment, it is a change in behaviour.

@agronholm
Copy link
Contributor

I still want to hear his use case to determine if we should fix this or not.

@carljm
Copy link

carljm commented Aug 28, 2020

Described the use case in #346 (comment)

@agronholm
Copy link
Contributor

I think this was fixed by #375 but I forgot to mention it in the release notes. Can you confirm?

@mattip
Copy link
Contributor Author

mattip commented Dec 1, 2020

I guess it would be nice to add a blurb like "Fixed regression in v35 where --plat-name was ignored for c-extension packages. Also fixed faulty test for this flag"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants