-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test_tagopy.test_plat_name_ext and setting plat-name on non-pure wheels #374
Comments
I still want to hear his use case to determine if we should fix this or not. |
Described the use case in #346 (comment) |
I think this was fixed by #375 but I forgot to mention it in the release notes. Can you confirm? |
I guess it would be nice to add a blurb like "Fixed regression in v35 where |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As fallout from #346, there was a change in behavior. Previously, a user could specify a
plat-name
andbdist_wheel
would create a binary wheel with thatplat-name
. This is tested for intest_plat_name_ext
. Before that PR the test passed, after it the test is skipped (the failed assert inget_tag
is misinterpreted as an inability to compile).Arguably, the previous behavior was
unintentionalintended but questionable sinceplat-name
As @carljm points out in this comment, it is a change in behaviour.
The text was updated successfully, but these errors were encountered: