better "register" guidance and pypi.org migration advice #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #320 +/- ##
=======================================
Coverage 68.51% 68.51%
=======================================
Files 12 12
Lines 578 578
Branches 91 91
=======================================
Hits 396 396
Misses 157 157
Partials 25 25
Continue to review full report at Codecov.
|
|
cc @mauritsvanrees & @mplanchard in case you can review & advise. |
|
LGTM. It makes things clearer. It does not look like this requires changes in Also, by default |
|
This looks good to me, too! |
jaraco
approved these changes
Mar 15, 2018
brainwane
force-pushed
the
pypi-migration-register
branch
from
f1d4f3b to
d15277e
Compare
brainwane
force-pushed
the
pypi-migration-register
branch
from
d15277e to
a578fd9
Compare
brainwane
changed the title
|
I think codecov is just broken right now. Disregarding it and merging. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address part of #11 and #311 by removing the pypi.org default for
register, and improving command-line usage forregister. Also improve style and provide better guidance in theREADMEand in other usage help forregisterandupload, including suggesting users use Test PyPI before uploading distributions to pypi.org.Once we get the usage wording down I'll also update the
READMEin this PR to reflect the new usage text foruploadandregister.Key line to review: https://github.com/pypa/twine/compare/pypi-migration-register?expand=1#diff-2190788b5d7d5b86131d0daf63dac4d1R72 in which I remove the default of
pypifor theregistercommand.