Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert package to PEP621 pyproject.toml #284

Closed
miketheman opened this issue Jun 18, 2023 · 1 comment
Closed

Convert package to PEP621 pyproject.toml #284

miketheman opened this issue Jun 18, 2023 · 1 comment

Comments

@miketheman
Copy link
Member

https://peps.python.org/pep-0621/
https://packaging.python.org/en/latest/specifications/declaring-project-metadata/#declaring-project-metadata

Some considerations need to be taken for current setup.py dynamic attributes from __about__.py:

readme_renderer/setup.py

Lines 21 to 23 in c6f1eab

with open(base_dir.joinpath("readme_renderer", "__about__.py")) as f:
about = {}
exec(f.read(), about)

readme_renderer/setup.py

Lines 30 to 37 in c6f1eab

name=about["__title__"],
version=about["__version__"],
description=about["__summary__"],
long_description=long_description,
license=about["__license__"],
url=about["__uri__"],
author=about["__author__"],
author_email=about["__email__"],

Some inspiration could be drawn from here: https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html#dynamic-metadata

Other values might be better served as static metadata.

@di
Copy link
Member

di commented Aug 28, 2023

Resolved by #293.

@di di closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants