Deprecate the --three flag #5328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
force-pushed
the
deprecate-three
branch
from
9bdf218
to
62cc990
Compare
matteius
reviewed
Sep 5, 2022
pipenv now uses python3 by default.
oz123
force-pushed
the
deprecate-three
branch
from
62cc990
to
6abc0e0
Compare
|
@matteius the breaks on Windows are unrelated to the change. It's that requests test again. |
The pypiserver PR will make those a non-issue, because they change to tests uvicorn and uvicorn[standard] instead of requests until we can sort out why requirementslib infers the specifier from setup metadata when none is specified. It was clearly an edge case of that expected behavior and cross test contamination. |
matteius
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipenv now uses python3 by default.
Following our discussion in #5304