Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit hooks similar to what pip has to pipenv #4993

Closed
matteius opened this issue Mar 19, 2022 · 0 comments
Closed

Add pre-commit hooks similar to what pip has to pipenv #4993

matteius opened this issue Mar 19, 2022 · 0 comments
Assignees
Labels
Category: Development Issue affects development workflow. PR: merged The PR related to this issue has been merged.

Comments

@matteius
Copy link
Member

Similar to how pip has pre-commit configuration: https://github.com/pypa/pip/blob/main/.pre-commit-config.yaml

It would be great for pipenv to adopt such linting tools as well. That way we don't have to debate stylistic differences on PRs or have things not flake8 complaints. sorting imports for example can be time consuming but with isort that becomes a non-issue. There are more benefits to be had as well.

Describe the solution you'd like

I will open a PR to try and add this supported. Would like to also have it run as part of the build process, and some help on the .githup action may be required, we'll see.

@matteius matteius self-assigned this Mar 19, 2022
@matteius matteius added the Category: Development Issue affects development workflow. label Mar 19, 2022
@matteius matteius added the PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. label Mar 19, 2022
@matteius matteius added PR: merged The PR related to this issue has been merged. and removed PR: awaiting-review The PR related to this issue is awaiting review by a maintainer. labels Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Development Issue affects development workflow. PR: merged The PR related to this issue has been merged.
Projects
None yet
Development

No branches or pull requests

1 participant