Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionable testimonials on docs.pipenv.org #4671

Closed
jamesmishra opened this issue Apr 13, 2021 · 8 comments
Closed

Questionable testimonials on docs.pipenv.org #4671

jamesmishra opened this issue Apr 13, 2021 · 8 comments
Labels
Priority: Critical This issue is critical and affects usability or core functionality. Type: Documentation 📖 This issue relates to documentation of pipenv.

Comments

@jamesmishra
Copy link

Issue description

https://docs.pipenv.org has five testimonials under the Testimonials header, and the first two testimonials contain hyperlinks to casual sex apps. To be clear, I am not making a moral judgement and if these apps are legitimate Pipenv consumers, feel free to close my issue as WONTFIX.

However, these testimonials' wording and hyperlinks make them look like spam. It also appears that these sex-related testimonials have not been checked into Git, which suggests that someone has tampered with the docs.pipenv.org deployment process.

A few of my friends have confirmed that they see the suspicious testimonials too, which suggests that the testimonials are not being inserted by malware local to my machines.

Steps to replicate

Visit https://docs.pipenv.org/

In case you cannot see what I can see, I have recorded a screenshot and the underlying HTML of the suspicious testimonials. The highlighting in the screenshot is mine.

weird-pipenv-testimonials

Finally, my apologies if I should have sent this to a security@ email address. I was not sure where to submit this issue.

@uranusjr
Copy link
Member

uranusjr commented Apr 13, 2021

Hmm, we’ve moved our documentation to pipenv.pypa.io instead (#4167), and I’m not even sure who owns the pipenv.org domain now. @pypa/pipenv-committers Anyone knows? We should do something about this.

@uranusjr uranusjr added Priority: Critical This issue is critical and affects usability or core functionality. Type: Documentation 📖 This issue relates to documentation of pipenv. labels Apr 13, 2021
@kennethreitz
Copy link
Contributor

Wow, this is a creative use of an expired domain.

I let pipenv.org expire, as it appeared few people used it, as opposed to the pypa site

@uranusjr
Copy link
Member

So that’s a fake website at this point. Anyone knows what we can do here?

@jamesmishra
Copy link
Author

Well, if nobody friendly owns the domain name, then I guess the right thing to do is submit *.pipenv.org to Google Safe Browsing and similar malware lists:

https://safebrowsing.google.com/safebrowsing/report_general/

@uranusjr
Copy link
Member

uranusjr commented Apr 13, 2021

👍 I’ve submitted a report with a link to this thread.

@jayvdb
Copy link
Contributor

jayvdb commented Dec 3, 2021

https://docs.pipenv.org/ now appearing as unsafe in Chrome, "security certificate expired 94 days ago"

@jamesmishra
Copy link
Author

That's because the scammer's servers are using a Let's Encrypt TLS certificate that is expired. I don't think anything prevents the scammer from renewing their certificate.

@elichad
Copy link

elichad commented Oct 8, 2022

FYI I found myself at the scam docs link via https://rootnroll.com/d/pipenv/ - which is currently linked from the front page of the real docs. I've opened a PR to fix that (linked above), but if it doesn't get merged, you may want to rethink referencing that page.

Edit: Now fixed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Critical This issue is critical and affects usability or core functionality. Type: Documentation 📖 This issue relates to documentation of pipenv.
Projects
None yet
Development

No branches or pull requests

5 participants