Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two doc fixes: ghbtns.com->https, added konami.js #2644

Merged
merged 3 commits into from
Jul 30, 2018
Merged

Conversation

javabrett
Copy link
Contributor

@javabrett javabrett commented Jul 25, 2018

Fixes the following site errors:

Mixed Content: The page at 'https://docs.pipenv.org/basics/' was loaded over HTTPS, but requested an insecure resource 'http://ghbtns.com/github-btn.html?user=kennethreitz&type=follow&count=true'. This request has been blocked; the content must be served over HTTPS.
konami.js:1 Failed to load resource: the server responded with a status of 404 (Not Found)
(index):572 Uncaught ReferenceError: Konami is not defined
    at (index):572

Fixed #2667 . Fixed #2668 .

@uranusjr
Copy link
Member

Wouldn’t it be better to make Konami work instead of removed?

@javabrett
Copy link
Contributor Author

Wouldn’t it be better to make Konami work instead of removed?

I don't know, is that what you are suggesting?

What I removed seemed to be fetching from http://fortunes.herokuapp.com/random/raw , also down/missing, seems unimportant - what is it supposed to do, and would you like to fix it? Or is Konami doing something else here?

@techalchemy
Copy link
Member

down/missing, seems unimportant

You opened a PR with no dialogue and no corresponding issue to remove something you didn't understand, but you think it seems unimportant?

I'm fairly confident Kenneth put it there, I doubt he would be thrilled if we just go around deciding it isn't important. He made the decision to include it, that is enough to make me hesitate before even considering if I can make the call on this.

I would encourage you to take a look at https://en.wikipedia.org/wiki/Wikipedia:Chesterton%27s_fence -- consider that someone built the fence before deciding it's not important and should be torn down

@javabrett javabrett changed the title Two doc fixes: ghbtns.com->https, removed Konami Two doc fixes: ghbtns.com->https, added konami.js Jul 26, 2018
@uranusjr uranusjr added the PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge. label Jul 30, 2018
@uranusjr uranusjr merged commit d4f710b into pypa:master Jul 30, 2018
@javabrett javabrett deleted the doc branch July 30, 2018 10:19
techalchemy added a commit that referenced this pull request Aug 1, 2018
Signed-off-by: Dan Ryan <dan@danryan.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: awaiting-merge The PR related to this issue has been reviewed and is awaiting merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants