Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly inform user we can’t allow certain packages to be pinned #2365

Open
uranusjr opened this issue Jun 15, 2018 · 0 comments
Open
Labels
Type: Discussion This issue is open for discussion. Type: Enhancement 💡 This is a feature or enhancement request.

Comments

@uranusjr
Copy link
Member

Via #2364. So it is probably not possible (without extensive project restructuring) to allow the user to install cetain packages. We should then tell the user that, instead of silently ignore the requirement.

A few points to discuss:

  • When should the message be triggered? IMO it should be shown when certain packages are pinned by someone (either top-level or not) to a version that does not satisfy the current installation.
    • 5.0 installed, >=4.3 specified -> No message
    • 5.0 installed, ~=4.0 specified -> message
  • What level should the message be? I think a warning would be enough (XXX dropped since it is required by Pipenv’s resolver), but a case can be made for an error (and locking failure).
@uranusjr uranusjr added Type: Enhancement 💡 This is a feature or enhancement request. Type: Discussion This issue is open for discussion. labels Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Discussion This issue is open for discussion. Type: Enhancement 💡 This is a feature or enhancement request.
Projects
None yet
Development

No branches or pull requests

1 participant