Implement heuristic to get non-ASCII ZIP entries #8684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
zipfile-unicode-path-python2
branch
from
fb0c51c
to
f14e4d0
Compare
|
IMO this isn't worth an automated test as long as we can manually validate it. I can't see any of this code needing to be changed before we drop Python 2, and the addition here is nice and self-contained (and easy to remove later). |
uranusjr
force-pushed
the
zipfile-unicode-path-python2
branch
from
9603130
to
3da7151
Compare
uranusjr
force-pushed
the
zipfile-unicode-path-python2
branch
from
3da7151
to
d4995cb
Compare
uranusjr
force-pushed
the
zipfile-unicode-path-python2
branch
from
3824286
to
a12e2f1
Compare
|
According to #8648 (comment), paths inside a wheel should always use UTF-8. This is a lot simpler than I initially thought. |
sbidoul
reviewed
Aug 3, 2020
sbidoul
approved these changes
Aug 3, 2020
pradyunsg
approved these changes
Aug 4, 2020
pradyunsg
added a commit
to pradyunsg/pip
that referenced
this pull request
Aug 4, 2020
bors bot
referenced
this pull request
in duckinator/emanate
Aug 5, 2020
158: Update pip to 20.2.1 r=duckinator a=pyup-bot This PR updates [pip](https://pypi.org/project/pip) from **20.2** to **20.2.1**. <details> <summary>Changelog</summary> ### 20.2.1 ``` =================== Features -------- - Ignore require-virtualenv in ``pip list`` (`8603 <https://github.com/pypa/pip/issues/8603>`_) Bug Fixes --------- - Correctly find already-installed distributions with dot (``.``) in the name and uninstall them when needed. (`8645 <https://github.com/pypa/pip/issues/8645>`_) - Trace a better error message on installation failure due to invalid ``.data`` files in wheels. (`8654 <https://github.com/pypa/pip/issues/8654>`_) - Fix SVN version detection for alternative SVN distributions. (`8665 <https://github.com/pypa/pip/issues/8665>`_) - New resolver: Correctly include the base package when specified with extras in ``--no-deps`` mode. (`8677 <https://github.com/pypa/pip/issues/8677>`_) - Use UTF-8 to handle ZIP archive entries on Python 2 according to PEP 427, so non-ASCII paths can be resolved as expected. (`8684 <https://github.com/pypa/pip/issues/8684>`_) Improved Documentation ---------------------- - Add details on old resolver deprecation and removal to migration documentation. (`8371 <https://github.com/pypa/pip/issues/8371>`_) - Fix feature flag name in docs. (`8660 <https://github.com/pypa/pip/issues/8660>`_) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pip - Changelog: https://pyup.io/changelogs/pip/ - Homepage: https://pip.pypa.io/ </details> Co-authored-by: pyup-bot <github-bot@pyup.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #8648. Not quite sure how to write a test for this yet. Is it even worthwhile given that Python 2 is going away in six months?