Abort pip cache commands when cache is disabled #8124

NoahGorny · 2020-04-24T09:37:27Z

Resolves #8120
Seems important enough to be included in this release

gutsytechster · 2020-04-24T09:45:35Z

src/pip/_internal/commands/cache.py

@@ -48,6 +48,11 @@ def run(self, options, args):
            "purge": self.purge_cache,
        }

+        if not options.cache_dir:
+            logger.error("Pip cache commands can not "


I think this should be pip instead of Pip :)

Yup. Otherwise LGTM.

Suggested change

logger.error("Pip cache commands can not "

logger.error("pip cache commands can not "

Nit: Should it be cannot instead of can not ?

I like can not more, but I am open to other ideas 😄
Also, thanks for the feedback guys! @uranusjr @gutsytechster @deveshks

deveshks · 2020-04-24T10:06:29Z

tests/functional/test_cache.py

+@pytest.mark.parametrize("command", ["info", "list", "remove", "purge"])
+def test_cache_abort_when_no_cache_dir(script, command):
+    """Running any pip cache command when cache is disabled should
+    abort and print informative answer"""


Nit: abort and log an error instead of abort and print informative answer

Take a look now @deveshks

Yep, looks good 😊

pfmoore · 2020-04-24T11:18:10Z

@pradyunsg This should be included in 20.1.0 final, but I'll leave you to make the final decision and merge as RM.

pradyunsg · 2020-04-24T23:01:42Z

@pfmoore Thanks for the mention! The corresponding issue had already been added. :)

Thanks @uranusjr @pfmoore and @xavfernandez for reviewing and @NoahGorny for the PR! ^>^

deveshks · 2020-04-28T17:17:14Z

Just saw that in the changelog docs for this bug, the issue number is 8124, (the PR number) , rather than 8120, which is the issue number.

I believe this is caused by the newsfile being named 8124.bugfix instead of 8120.bugfix

How do we generally fix such a thing (do we just manually modify https://github.com/pypa/pip/blob/master/NEWS.rst ? ). I see a few other links in changelog pointing to PRs as well.

NoahGorny · 2020-04-28T17:45:40Z

Oh no, I did not know it should point to the issue number and not the PR one :(
Big mistake of mine :sad:

uranusjr · 2020-04-28T17:50:57Z

I think it’s fine either way. Of course it’s preferrable to point to the issue, but it doesn’t matter much in this case since it only takes minimal amount of time to find the corresponding issue from this PR anyway.

pradyunsg · 2020-04-29T01:27:17Z

It's certainly not a big deal or a big mistake in any way. The point of those references in the changelog, is to provide a way for folks to get to the corresponding discussion and implementation, which is clearly still possible.

If someone somehow gets mad/annoyed that they had to click 1 more time than for other news entries to get to the issue... well, they can file a PR changing NEWS.rst. :)

118: Update pip to 20.1 r=duckinator a=pyup-bot This PR updates [pip](https://pypi.org/project/pip) from **20.0.2** to **20.1**. <details> <summary>Changelog</summary> ### 20.1 ``` ================= Process ------- - Document that pip 21.0 will drop support for Python 2.7. Features -------- - Add ``pip cache dir`` to show the cache directory. (`7350 <https://github.com/pypa/pip/issues/7350>`_) Bug Fixes --------- - Abort pip cache commands early when cache is disabled. (`8124 <https://github.com/pypa/pip/issues/8124>`_) - Correctly set permissions on metadata files during wheel installation, to permit non-privileged users to read from system site-packages. (`8139 <https://github.com/pypa/pip/issues/8139>`_) ``` ### 20.1b1 ``` =================== Deprecations and Removals ------------------------- - Remove emails from AUTHORS.txt to prevent usage for spamming, and only populate names in AUTHORS.txt at time of release (`5979 <https://github.com/pypa/pip/issues/5979>`_) - Remove deprecated ``--skip-requirements-regex`` option. (`7297 <https://github.com/pypa/pip/issues/7297>`_) - Building of local directories is now done in place, instead of a temporary location containing a copy of the directory tree. (`7555 <https://github.com/pypa/pip/issues/7555>`_) - Remove unused ``tests/scripts/test_all_pip.py`` test script and the ``tests/scripts`` folder. (`7680 <https://github.com/pypa/pip/issues/7680>`_) Features -------- - pip now implements PEP 610, so ``pip freeze`` has better fidelity in presence of distributions installed from Direct URL requirements. (`609 <https://github.com/pypa/pip/issues/609>`_) - Add ``pip cache`` command for inspecting/managing pip's wheel cache. (`6391 <https://github.com/pypa/pip/issues/6391>`_) - Raise error if ``--user`` and ``--target`` are used together in ``pip install`` (`7249 <https://github.com/pypa/pip/issues/7249>`_) - Significantly improve performance when ``--find-links`` points to a very large HTML page. (`7729 <https://github.com/pypa/pip/issues/7729>`_) - Indicate when wheel building is skipped, due to lack of the ``wheel`` package. (`7768 <https://github.com/pypa/pip/issues/7768>`_) - Change default behaviour to always cache responses from trusted-host source. (`7847 <https://github.com/pypa/pip/issues/7847>`_) - An alpha version of a new resolver is available via ``--unstable-feature=resolver``. (`988 <https://github.com/pypa/pip/issues/988>`_) Bug Fixes --------- - Correctly freeze a VCS editable package when it is nested inside another VCS repository. (`3988 <https://github.com/pypa/pip/issues/3988>`_) - Correctly handle ``%2F`` in URL parameters to avoid accidentally unescape them into ``/``. (`6446 <https://github.com/pypa/pip/issues/6446>`_) - Reject VCS URLs with an empty revision. (`7402 <https://github.com/pypa/pip/issues/7402>`_) - Warn when an invalid URL is passed with ``--index-url`` (`7430 <https://github.com/pypa/pip/issues/7430>`_) - Use better mechanism for handling temporary files, when recording metadata about installed files (RECORD) and the installer (INSTALLER). (`7699 <https://github.com/pypa/pip/issues/7699>`_) - Correctly detect global site-packages availability of virtual environments created by PyPA’s virtualenv>=20.0. (`7718 <https://github.com/pypa/pip/issues/7718>`_) - Remove current directory from ``sys.path`` when invoked as ``python -m pip <command>`` (`7731 <https://github.com/pypa/pip/issues/7731>`_) - Stop failing uninstallation, when trying to remove non-existent files. (`7856 <https://github.com/pypa/pip/issues/7856>`_) - Prevent an infinite recursion with ``pip wheel`` when ``$TMPDIR`` is within the source directory. (`7872 <https://github.com/pypa/pip/issues/7872>`_) - Significantly speedup ``pip list --outdated`` by parallelizing index interaction. (`7962 <https://github.com/pypa/pip/issues/7962>`_) - Improve Windows compatibility when detecting writability in folder. (`8013 <https://github.com/pypa/pip/issues/8013>`_) Vendored Libraries ------------------ - Update semi-supported debundling script to reflect that appdirs is vendored. - Add ResolveLib as a vendored dependency. - Upgrade certifi to 2020.04.05.1 - Upgrade contextlib2 to 0.6.0.post1 - Upgrade distro to 1.5.0. - Upgrade idna to 2.9. - Upgrade msgpack to 1.0.0. - Upgrade packaging to 20.3. - Upgrade pep517 to 0.8.2. - Upgrade pyparsing to 2.4.7. - Remove pytoml as a vendored dependency. - Upgrade requests to 2.23.0. - Add toml as a vendored dependency. - Upgrade urllib3 to 1.25.8. Improved Documentation ---------------------- - Emphasize that VCS URLs using git, git+git and git+http are insecure due to lack of authentication and encryption (`1983 <https://github.com/pypa/pip/issues/1983>`_) - Clarify the usage of --no-binary command. (`3191 <https://github.com/pypa/pip/issues/3191>`_) - Clarify the usage of freeze command in the example of Using pip in your program (`7008 <https://github.com/pypa/pip/issues/7008>`_) - Add a "Copyright" page. (`7767 <https://github.com/pypa/pip/issues/7767>`_) - Added example of defining multiple values for options which support them (`7803 <https://github.com/pypa/pip/issues/7803>`_) ``` </details> <details> <summary>Links</summary> - PyPI: https://pypi.org/project/pip - Changelog: https://pyup.io/changelogs/pip/ - Homepage: https://pip.pypa.io/ </details> Co-authored-by: pyup-bot <github-bot@pyup.io>

nabeel0954 · 2021-04-21T06:50:31Z

i am faceing this issue please help me anybody ERROR: pip cache commands can not function since cache is disabled.

NoahGorny force-pushed the abort-cache-when-no-cache-dir branch from 3ca1b9f to 410dfa1 Compare April 24, 2020 09:39

NoahGorny changed the title ~~Abort cache when no cache dir~~ Abort pip cache commands when cache is disabled Apr 24, 2020

gutsytechster reviewed Apr 24, 2020

View reviewed changes

commands: cache: Abort early if cache is disabled

e212f66

NoahGorny force-pushed the abort-cache-when-no-cache-dir branch from 410dfa1 to c02fc79 Compare April 24, 2020 09:58

deveshks reviewed Apr 24, 2020

View reviewed changes

tests: commands: cache: Add no-cache-dir test case

8c28b81

NoahGorny force-pushed the abort-cache-when-no-cache-dir branch from c02fc79 to 8c28b81 Compare April 24, 2020 10:09

uranusjr approved these changes Apr 24, 2020

View reviewed changes

pfmoore approved these changes Apr 24, 2020

View reviewed changes

xavfernandez added this to the 20.1 milestone Apr 24, 2020

xavfernandez approved these changes Apr 24, 2020

View reviewed changes

pradyunsg merged commit 6a7bf94 into pypa:master Apr 24, 2020

deveshks mentioned this pull request Apr 26, 2020

Repeated message about cache being disabled if pip cache is run with sudo #8142

Closed

github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Abort pip cache commands when cache is disabled #8124

Abort pip cache commands when cache is disabled #8124

NoahGorny commented Apr 24, 2020

gutsytechster Apr 24, 2020

uranusjr Apr 24, 2020

deveshks Apr 24, 2020

NoahGorny Apr 24, 2020

deveshks Apr 24, 2020

NoahGorny Apr 24, 2020

deveshks Apr 24, 2020

pfmoore commented Apr 24, 2020

pradyunsg commented Apr 24, 2020

deveshks commented Apr 28, 2020 •

edited

Loading

NoahGorny commented Apr 28, 2020

uranusjr commented Apr 28, 2020

pradyunsg commented Apr 29, 2020 •

edited

Loading

nabeel0954 commented Apr 21, 2021

	logger.error("Pip cache commands can not "
	logger.error("pip cache commands can not "

Abort pip cache commands when cache is disabled #8124

Abort pip cache commands when cache is disabled #8124

Conversation

NoahGorny commented Apr 24, 2020

gutsytechster Apr 24, 2020

Choose a reason for hiding this comment

uranusjr Apr 24, 2020

Choose a reason for hiding this comment

deveshks Apr 24, 2020

Choose a reason for hiding this comment

NoahGorny Apr 24, 2020

Choose a reason for hiding this comment

deveshks Apr 24, 2020

Choose a reason for hiding this comment

NoahGorny Apr 24, 2020

Choose a reason for hiding this comment

deveshks Apr 24, 2020

Choose a reason for hiding this comment

pfmoore commented Apr 24, 2020

pradyunsg commented Apr 24, 2020

deveshks commented Apr 28, 2020 • edited Loading

NoahGorny commented Apr 28, 2020

uranusjr commented Apr 28, 2020

pradyunsg commented Apr 29, 2020 • edited Loading

nabeel0954 commented Apr 21, 2021

deveshks commented Apr 28, 2020 •

edited

Loading

pradyunsg commented Apr 29, 2020 •

edited

Loading