Fix logging of cached response #7393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrahunt
reviewed
Nov 23, 2019
xavfernandez
force-pushed
the
log_cached_response
branch
from
f6a2094
to
6538d11
Compare
|
Test added (which caused #7397) |
chrahunt
approved these changes
Nov 25, 2019
Cached responses often (always ?) provide a length meaning they were never logged as such.
xavfernandez
force-pushed
the
log_cached_response
branch
from
6538d11
to
02d3fe5
Compare
|
Thanks for the reviews :) |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cached responses often (always ?) provide a length meaning they were
never logged as such.
Not sure if a test is needed: it would involve passing a mocked response to
_prepare_downloadand checking if the caplogs contains "Using cached"...