Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 19.2 #6630

Closed
pradyunsg opened this issue Jun 21, 2019 · 39 comments
Closed

Release 19.2 #6630

pradyunsg opened this issue Jun 21, 2019 · 39 comments
Assignees
Labels
auto-locked Outdated issues that have been locked by automation type: maintenance Related to Development and Maintenance Processes
Milestone

Comments

@pradyunsg
Copy link
Member

THE TIME HAS COME FOR CHOOSING A RELEASE MANAGER!


More seriously, we're almost at July so we should probably figure out our RM and whether we should have a release.

@pradyunsg pradyunsg added the type: maintenance Related to Development and Maintenance Processes label Jun 21, 2019
@pradyunsg
Copy link
Member Author

I'm up for it and am happy to defer it if someone wants to be the RM.

IMO, we have enough things in master to justify a new release (news/ has ~11 feature and bugfix files each, as on today).

@pradyunsg pradyunsg assigned pradyunsg and unassigned pradyunsg Jun 21, 2019
@pradyunsg
Copy link
Member Author

pradyunsg commented Jun 21, 2019

(accidentally assigned myself coz pressing p<enter> assigned me instead of pypa/pip-committers)

On that note, pinging @pypa/pip-committers.

@pradyunsg
Copy link
Member Author

Hmm... Does this mean I am the release manager for 19.2?

@xavfernandez
Copy link
Member

Hmm... Does this mean I am the release manager for 19.2?

That would be nice 😊.

I'd like to take care of one of the next, but for this one, I'm not sure I'll have the time to properly handle it.

@pradyunsg pradyunsg self-assigned this Jul 6, 2019
@pradyunsg pradyunsg added this to the 19.2 milestone Jul 6, 2019
@pradyunsg pradyunsg pinned this issue Jul 6, 2019
@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 14, 2019

I'd like to take care of one of the next, but for this one, I'm not sure I'll have the time to properly handle it.

@xavfernandez What's your PyPI username?

@pradyunsg
Copy link
Member Author

I'll make the release in this week, optimistically. 🙃

@xavfernandez
Copy link
Member

@xavfernandez What's your PyPI username?

xafer

@pradyunsg
Copy link
Member Author

Final TODO items:

  • Python 2 deprecation message update
  • Update vendored dependencies
  • Release Engineering

@yan12125
Copy link
Contributor

As a side note, currently invoke vendoring.update is broken (I encountered this issue when trying to patch html5lib in #6728), and a possible fix is available at #6606.

@xavfernandez
Copy link
Member

Ideally, some basic documentation would be added for the new debug command...

@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 18, 2019

I won't have the bandwidth to add the docs for debug. If anything, I think I'll add a message saying "don't parse this output" and then we can address the lack of docs after the release.

If someone else wants to get that done, it's best to file a PR in the next 24 hours for it. I'm hoping to make the release this weekend or on Monday, if I'm feeling too tired.

@xavfernandez
Copy link
Member

@pradyunsg I'm adding the basic files.

@xavfernandez
Copy link
Member

Cf #6731

@pradyunsg
Copy link
Member Author

Awesome @xavfernandez! :D

@pradyunsg
Copy link
Member Author

Filed #6732.

@pradyunsg
Copy link
Member Author

Python 2 deprecation message update

#6726

Update vendored dependencies

#6749

@pradyunsg
Copy link
Member Author

Okai. I'm happy to make a release with how master looks now.

There's a bunch of approved PRs wrt tests and code cleanups -- I'm going to merge them and trust that they don't break stuff. 🌈

@pradyunsg
Copy link
Member Author

I'll be doing the release engineering today.

19.2 will be based off of 8582f7e.

@pradyunsg
Copy link
Member Author

19.2 has been released. May there not be any bug reports. ;)

@pradyunsg pradyunsg changed the title 19.2 is coming! 19.2 is released! Jul 23, 2019
@pfmoore
Copy link
Member

pfmoore commented Jul 23, 2019

One thought - maybe the release note could mention that while the upgrade should be painless, we would (of course) recommend that users test the release before deploying in production, as with any other software release. (The idea being to try to prevent problems going widespread like the ones we had in the last release).

@genesem

This comment has been minimized.

@pradyunsg
Copy link
Member Author

  • 19.2.1 has been uploaded on PyPI!
  • get-pip.py has also been updated.

@johnthagen
Copy link
Contributor

@pradyunsg I didn't realize 19.2.1 was released until finding this issue. Do the docs still need to be rebuilt? I only see 19.2 on https://pip.pypa.io/en/stable/news/.

Thanks.

@pradyunsg
Copy link
Member Author

pradyunsg commented Jul 24, 2019

Ah, thanks for chiming in @johnthagen! This should be fixed in a bit.

I'd accidentally pushed the 19.2 tag again, when pushing tags, instead of pushing the 19.2.1 git tag. Corrected that error. :)

@pradyunsg
Copy link
Member Author

Alrighty, all good then. :)

@johnthagen
Copy link
Contributor

@pradyunsg Looks great now! :)

@pradyunsg pradyunsg unpinned this issue Jul 31, 2019
@pradyunsg
Copy link
Member Author

There's gonna be a 19.2.2. My current plan is to cherry-pick the following off the 19.2.1 tag:

I expect I'll make the release sometime next week so lemme know if there's any concerns w.r.t. this. :)

@pradyunsg pradyunsg changed the title 19.2 is released! 19.2.1 is released! 19.2.2 is coming! Aug 4, 2019
@pradyunsg pradyunsg pinned this issue Aug 4, 2019
@pradyunsg
Copy link
Member Author

Oh heck.

I completely forgot about this in PyCon Korea prep. Working on this now.

@pradyunsg
Copy link
Member Author

ISTM that we need to update our release process notes for bugfix releases. :)

@pradyunsg
Copy link
Member Author

@pradyunsg pradyunsg changed the title 19.2.1 is released! 19.2.2 is coming! 19.2.2 is released! Aug 11, 2019
@pradyunsg
Copy link
Member Author

Okay, I'll be hopping onto a flight tomorrow evening -- ~20 hours from now. I'm plan to call it done with this release by then; barring any new bug reports of course. :)

@pradyunsg
Copy link
Member Author

All done for 19.2 then.

Thanks everyone who contributed to this release and especially those who flagged issues and/or helped resolved them! ^>^

@pradyunsg pradyunsg reopened this Aug 25, 2019
@pradyunsg
Copy link
Member Author

pradyunsg commented Aug 25, 2019

The fix for #6885, needs to make it into 3.8.0's final beta, that's due tomorrow.

Thus, I'm cutting a 19.2.3 off 19.2.2, with just one merge cherry-picked: 54eedbd.

EDIT: including 0b23e2d, since I don't wanna deal with merge conflicts.

@pradyunsg
Copy link
Member Author

pradyunsg commented Aug 25, 2019

@pradyunsg pradyunsg changed the title 19.2.2 is released! 19.2.3 is released! Aug 25, 2019
@pradyunsg
Copy link
Member Author

All done!

@mihaic
Copy link

mihaic commented Aug 27, 2019

Shouldn't the "stable" release notes include this release?
https://pip.pypa.io/en/stable/news/
The "latest" release notes have it:
https://pip.pypa.io/en/latest/news/

@pradyunsg
Copy link
Member Author

Hmm... seems like the docs build is failing.

@pradyunsg
Copy link
Member Author

pradyunsg commented Aug 28, 2019

Okay, fixed that.

Managed a successful "stable" docs build with the older, non-YAML based configuration with different (older) file structure in the repository.

@chrahunt chrahunt mentioned this issue Sep 8, 2019
@pradyunsg pradyunsg unpinned this issue Sep 8, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Sep 27, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 27, 2019
@pradyunsg pradyunsg changed the title 19.2.3 is released! Release 19.2 Nov 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

No branches or pull requests

8 participants