Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RECORD file when data file name contains comma #6103

Closed
ronaldoussoren opened this issue Dec 31, 2018 · 3 comments
Closed

RECORD file when data file name contains comma #6103

ronaldoussoren opened this issue Dec 31, 2018 · 3 comments
Labels
auto-locked Outdated issues that have been locked by automation

Comments

@ronaldoussoren
Copy link

Environment

  • pip version: 18.1
  • Python version: 3.7.1
  • OS: macOS 14.1
  • wheel: 0.32.3

Description

I'm not sure if this is an issue in pip, it might also be a problem with wheel or just unexpected behaviour.

I have a package containing a datafile that has a comma in its file name. When creating a wheel and then installing that wheel the RECORD file contains two lines:

package/other,data.dat,sha256=9jljVen42HXtXHKL7kl6flBZmawA_EkJI0VxHGxlzOs,10
"package/other,data.dat",,

The first line is also present in the generated wheel file, the second is added by pip.

Expected behavior

I'd expect 1 line for the file. If PEP 372 is the specification for the format of wheels the RECORD file should be a CSV file and the correct line would be:

"package/other,data.dat",sha256=9jljVen42HXtXHKL7kl6flBZmawA_EkJI0VxHGxlzOs,10

How to Reproduce

I've attached an sdist that contains a datafile as described above.

simple-package-1.0.tar.gz

Output

N/A, see rest of this issue.

@pfmoore
Copy link
Member

pfmoore commented Dec 31, 2018

Looks like a bug in wheel - see https://github.com/pypa/wheel/blob/master/wheel/wheelfile.py#L151. I suggest you report it to them.

@ronaldoussoren
Copy link
Author

I agree. I've opened an issue in the wheel repo.

@lock
Copy link

lock bot commented May 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label May 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

No branches or pull requests

2 participants