Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New upgrade-strategy eager-while-respecting-dependencies #5804

Closed
bersbersbers opened this issue Sep 21, 2018 · 5 comments
Closed

New upgrade-strategy eager-while-respecting-dependencies #5804

bersbersbers opened this issue Sep 21, 2018 · 5 comments
Labels
auto-locked Outdated issues that have been locked by automation

Comments

@bersbersbers
Copy link

What's the problem this feature will solve?
Image you are working with the newest version of package A that depends on B==2. You have B==1 installed, and the most recent version is B==3.

How do you upgrade to the newest allowed version of B, B==2, without going through all dependencies of A manually? If I am not mistaken,
pip install A --upgrade [--upgrade-strategy only-if-needed] keeps B==1
pip install A --upgrade --upgrade-strategy eager updates to B==3
pip-review --interactive will (offer to) upgrade to B==3

A concrete example:
pip install PyInstaller --upgrade --upgrade-strategy eager will upgrade to setuptools==40.4.1, even though tensorflow-gpu==1.11.0rc1 is installed, which requires setuptools<=39.1.0.

Describe the solution you'd like
pip install A --upgrade --upgrade-strategy eager-while-respecting-dependencies could solve that, parsing the dependency tree for the maximum allowed version of B and upgrading to that one.

@RonnyPfannschmidt
Copy link
Contributor

sounds like a duplicate of #988

@bersbersbers
Copy link
Author

@RonnyPfannschmidt I agree, yes. My specific question about a new upgrade-strategy is a bit more specific than that huge discussion over there, but it captures the essence of my problem.

@RonnyPfannschmidt
Copy link
Contributor

@bersbersbers my understanding is that solving #988 would sort out the issue you see with eager updates correctly, and making that particular update strategy actually work would require it to begin with

@bersbersbers
Copy link
Author

Agreed!

@lock
Copy link

lock bot commented Jun 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

No branches or pull requests

2 participants