Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI - Improvements #4478

Closed
pradyunsg opened this issue May 13, 2017 · 17 comments
Closed

Travis CI - Improvements #4478

pradyunsg opened this issue May 13, 2017 · 17 comments
Labels
auto-locked Outdated issues that have been locked by automation

Comments

@pradyunsg
Copy link
Member

pradyunsg commented May 13, 2017

Are the pip developers comfortable with using Travis CI beta features?


There are 2 Travis CI features in public beta right now - Build Stages and Auto Cancellation. I think these can be used to cause fast failing and potentially reduce the build queue times.

With Build Stages, I'd imagine there would be the following stages (in this order):

  • unit tests
  • integration tests
  • pep8 + documentation + packaging

This would nearly double the number of jobs run since currently unit tests and integration tests are run in the same job.

Edit: I just tried it out and I don't think this is useful for pip's CI usage.

Auto Cancellation is definitely a win regardless of whether Build Stages are useful for pip.


(edited to condense multiple posts into 1)

@pradyunsg pradyunsg changed the title Travis CI - Build Stages Travis CI - Using Beta Features May 13, 2017
@pradyunsg
Copy link
Member Author

Also, what are your thoughts on running tests verbose (pytest -v)?

@xavfernandez
Copy link
Member

  • Build stages 👍
  • Auto cancel seems like a good idea for pull request builds but I'd rather still have a build for each commit/merge on master
  • Concerning pytest -v I'm 👍 also :)

@dstufft
Copy link
Member

dstufft commented May 13, 2017

I've already got auto cancellation turned on (though I have it turned on for both branches and PRs, largely because our tests take forever). I agree that I don't think that build stages are incredibly useful for pip. As far as pytest -v goes, I am neutral on it. I am happy to have it go either way.

@pradyunsg
Copy link
Member Author

Cool. I'll make a PR for adding a -v. XD

@pradyunsg
Copy link
Member Author

Oh, one last thing - @dstufft: currently pull requests titles are modified to add the Reviewable tag through your account. It would look nicer if pypa-bot did it. :)

And since I think there's nothing actionable left, I'll close this issue.

@dstufft
Copy link
Member

dstufft commented May 14, 2017

What reviewable tag?

@pradyunsg
Copy link
Member Author

The edit to add "This change is reviewable" - Does anyone even use that?

image

@dstufft
Copy link
Member

dstufft commented May 14, 2017

I thought I turned that off, turned it off for real now.

@pradyunsg
Copy link
Member Author

Now, I think I'm just gonna use this issue for random questions about CI I have. Is there a better channel/place to do that?


Thoughts on enforcing import order using an additional tox job - using isort?

@pradyunsg
Copy link
Member Author

pradyunsg commented May 15, 2017

Thoughts on enforcing import order using an additional tox job - using isort?

I just opened #4481.

@pradyunsg pradyunsg changed the title Travis CI - Using Beta Features Travis CI - Improvements May 18, 2017
@pradyunsg
Copy link
Member Author

pradyunsg commented May 18, 2017

I'm opening this back up. I'll use this to as a place to ask CI questions as long as I'm working on #4497.

@pradyunsg pradyunsg reopened this May 18, 2017
@pradyunsg
Copy link
Member Author

Thoughts on adding Jython testing on Travis CI and AppVeyor?

I think it'd have to be clone, install then do the testing but it seems be do-able and I think it'll might worthwhile to do so.

@pradyunsg
Copy link
Member Author

pradyunsg commented Jun 13, 2017

Thoughts on skipping a CI test-run if a commit-set does not touch any file within pip/ or tests/?

FWIW, cpython does it.

@pradyunsg
Copy link
Member Author

I guess making new issues is easy enough. :P

@pradyunsg
Copy link
Member Author

Thoughts on skipping a CI test-run if a commit-set does not touch any file within pip/ or tests/?

Opened #5185.

Thoughts on adding Jython testing on Travis CI and AppVeyor?

There's #3044 already.

@pfmoore
Copy link
Member

pfmoore commented Apr 7, 2018

Note that Jython is not a supported target for pip (and I think there's at least one issue that we closed unfixed because we weren't able to support the quirk of Jython that triggered the problem).

@lock
Copy link

lock bot commented Jun 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Jun 2, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation
Projects
None yet
Development

No branches or pull requests

4 participants