Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pickled tags don't == tags from parsed filenames with same str() representation? #859

Open
dholth opened this issue Dec 2, 2024 · 2 comments · May be fixed by #860
Open

Pickled tags don't == tags from parsed filenames with same str() representation? #859

dholth opened this issue Dec 2, 2024 · 2 comments · May be fixed by #860
Labels
bug packaging.tags

Comments

@dholth
Copy link
Member

dholth commented Dec 2, 2024

I tried pickling some tags and evaluating them in a different interpreter, and tag1 != tag2 even though str(tag1) == str(tag2). Is this intentional?
@dholth dholth linked a pull request Dec 2, 2024 that will close this issue
Open
@Siddhesh-Agarwal
Copy link
Contributor

Siddhesh-Agarwal commented Jan 9, 2025 •
edited
Loading

Do you think the __eq__
function needs an update?

@uranusjr
Copy link
Member

uranusjr commented Jan 9, 2025

No, I think the PR linked above #860 has the correct solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug packaging.tags
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update _hash when unpickling Tag() dholth/packaging
4 participants
@brettcannon @dholth @uranusjr @Siddhesh-Agarwal