Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute wheel content hashes once #189

Open
ralbertazzi opened this issue May 30, 2023 · 0 comments
Open

Compute wheel content hashes once #189

ralbertazzi opened this issue May 30, 2023 · 0 comments
Labels
component: core Related to core installation logic type: feature A self-contained enhancement or new feature

Comments

@ralbertazzi
Copy link

installer computes hashes over a wheel both on:

This isn't ideal when validating and installing gigantic wheels, such as this 2.1 GB torch distribution.

  • Installation with validation with validate_contents = True takes 97 s
  • Installation with validation with validate_contents = False takes 55 s
  • In comparison, pip install (used through poetry with config installer.modern-installation false) takes 51 s

It would be great to keep content validation while avoiding computing hashes twice. I tried to implement it in a hackish way in python-poetry/poetry#8027, but this should be solved inside installer itself.
@ralbertazzi ralbertazzi mentioned this issue May 30, 2023
Closed
3 tasks
@pradyunsg pradyunsg added the type: feature A self-contained enhancement or new feature label May 30, 2023
@Secrus Secrus added the component: core Related to core installation logic label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: core Related to core installation logic type: feature A self-contained enhancement or new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pradyunsg @ralbertazzi @Secrus