-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nuget error on Travis #653
Conversation
Before you put too much time into this, @joerick: is it worth it? travis-ci.org is still saying it's soon shutting down and we should all switch to www.travis-ci.com and beg for free credits as open source project. |
I'd be happy to drop Travis support, I don't use it and it's a disproportionate pain to maintain. Maybe dropping Travis support is a 2.0 thing? |
See my email. Also, about 13 or so of our known users (still) use travis (may need an update, though, I know boost-histogram has dropped it ;) ) Travis Windows is pretty rare, though. |
Well, to be fair, my take on this is: they did that to themselves. I'm mostly worried that even if we keep supporting Travis CI, we'd need to switch to travis-ci.com anyway, which might have a slightly different way of configuring things. |
(I'm also not stopping you, btw. If you have time and want to get this working, be my guest, but I thought it was worth mentioning :-) ) |
I think I figured this one out already :) But thank you for bringing it up, I've been meaning to do the same for a while. On top of changes like these that need workarounds, it does seem that it's the most flaky of the CIs that we support. Additionally, there's the business-level stuff. They seem to be delaying on actually flipping the switch on travis-ci.org changeover, I'm not sure why. I'm not sure how things will work once we make the switch, but I've little interest in doing open-source work to support them if they're not supporting open-source with their service. So if that's how things look after the switch, I'd be in favour of dropping our support on principle. |
I entirely, full-heartedly agree here! In some way, we'd be doing them a favor by keeping up support, so I don't feel like jumping through a bunch of hoops to keep up support. |
Technically, this helped our GHA support too. ;) |
Fix this error on Travis:
The problem seems to be that Travis added a blank nuget config file at
%AppData%\NuGet\NuGet.Config
, so nuget didn't know where to fetch its packages from. This PR adds aFallbackSource
via the command line, so regardless of config files, nuget can find the registry.