mention apt-get for manylinux2_24 #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
commented
Mar 18, 2021
| manylinux2010 and manylinux2014 builds occur inside a CentOS one. So for | ||
| `manylinux2_24` the `CIBW_BEFORE_ALL_LINUX` command must use `apt-get -y` | ||
| instead. | ||
|
|
There was a problem hiding this comment.
This is the added blurb, it kind of got lost in the reflow.
There was a problem hiding this comment.
Yeah, GH's ignore whitespace doesn't work on reflowing things.
There was a problem hiding this comment.
What about the whitespace? If we want to do this, we should probably be consistent (and do it in a different PR) ?
I can push a commit to minimize the diff, if you want?
There was a problem hiding this comment.
Alright, I did so (together with a minor typo). Feel free to kick out the last commit (67903ae) again, if you disagree :-)
henryiii
approved these changes
Mar 18, 2021
henryiii
reviewed
Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add mentions of
apt-getfor manylinux2_24, also reflow the faq.md document for 80 columns