-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto32/auto64 #553
feat: auto32/auto64 #553
Conversation
8e8935b
to
7ccca9e
Compare
I've rebased on top of #545 since it looks like that one will go in. When looking at this PR, just look at the last commit. Looks like #545 is based on a slightly older master than I intended, so the I've also normalized a names in the tests for better consistency; could have gone into #545 but didn't realize it at the time I pushed that one. |
@joerick and/or @YannickJadoul Feel free to look at 7ccca9e by itself to speed up the process, as soon as #545 goes in that's what I'll rebase on master. |
#545 is the last PR for 1.8.0, otherwise we'll never get it out! I think the docs currently on master are fine for documenting the emulation use-case, so we don't need to rush to get this in. |
b071603
to
e197595
Compare
e197595
to
bc36361
Compare
c0828f1
to
2869a76
Compare
2869a76
to
e14d13d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Add
auto32
/auto64
.Closes #551.