Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto32/auto64 #553

Merged
merged 3 commits into from
Feb 1, 2021
Merged

feat: auto32/auto64 #553

merged 3 commits into from
Feb 1, 2021

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jan 21, 2021

Add auto32/auto64.

Closes #551.

@henryiii henryiii marked this pull request as draft January 21, 2021 19:13
@henryiii
Copy link
Contributor Author

I've rebased on top of #545 since it looks like that one will go in. When looking at this PR, just look at the last commit. Looks like #545 is based on a slightly older master than I intended, so the CIBW_ARCHS README change isn't picked up, so I'll re-rebase when #545 is in. @joerick I've updated the docs quite a bit on CIBW_ARCHS, to be more consistent with the rest of the options, especially now that we have some useful on-all-platforms arch settings. It would be great if we could get this in as the last PR before 1.8.0.

I've also normalized a names in the tests for better consistency; could have gone into #545 but didn't realize it at the time I pushed that one.

@henryiii
Copy link
Contributor Author

@joerick and/or @YannickJadoul Feel free to look at 7ccca9e by itself to speed up the process, as soon as #545 goes in that's what I'll rebase on master.

@joerick
Copy link
Contributor

joerick commented Jan 22, 2021

#545 is the last PR for 1.8.0, otherwise we'll never get it out! I think the docs currently on master are fine for documenting the emulation use-case, so we don't need to rush to get this in.

@henryiii henryiii force-pushed the feat/bitiness branch 2 times, most recently from b071603 to e197595 Compare January 22, 2021 22:04
@henryiii henryiii marked this pull request as ready for review January 24, 2021 00:59
Copy link
Contributor

@joerick joerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@henryiii henryiii merged commit 70d9e1d into pypa:master Feb 1, 2021
@henryiii henryiii deleted the feat/bitiness branch February 1, 2021 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Idea: Arch 32/64 shortcut
2 participants