Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsupported platform tag linux_* instead of manylinux_* generated #1929

Closed
LecrisUT opened this issue Jul 9, 2024 · 3 comments
Closed

unsupported platform tag linux_* instead of manylinux_* generated #1929

LecrisUT opened this issue Jul 9, 2024 · 3 comments

Comments

@LecrisUT
Copy link

LecrisUT commented Jul 9, 2024

Description

I am not sure whether this is a cibuildweel, scikit-build-core or a more general issue, but the generated artifacts that I get recently have an unsupported tag for PyPI spglib-2.5.1.dev3+g0028515-cp311-cp311-linux_aarch64.whl compared to 3 months ago spglib-2.4.0-cp311-cp311-manylinux_2_17_aarch64.whl. I've considered that this could be fixed by #1917, but updating the action did not fix it. Any ideas what is going on?

Failed release: https://github.com/spglib/spglib/actions/runs/9851199010
Updated action: spglib/spglib#507

Tagging @henryiii


Might be an issue with not running auditwheel?

@henryiii
Copy link
Contributor

henryiii commented Jul 9, 2024

It's a scikit-build-core update, we were hit by this bug in packaging; we never intended to produce "many"/"musl" in our tag names - we don't run auditwheel for you! You are disabling auditwheel: https://github.com/spglib/spglib/blob/3368f9eed4c74972f997558069cd3146d173b659/pyproject.toml#L108 so the wheels are not guaranteed to run on many linuxes.

If you had do to this, you could use wheel tags --remove --platform-tag manylinux_2_17_aarch64 {wheel} as your repair command, but I'd highly recommend fixing auditwheel instead.

@LecrisUT
Copy link
Author

LecrisUT commented Jul 9, 2024

Yeah, I'm hitting the issue that I don't want the RPATH to be patched for the wheel, but then the audit fails because it is trying to fix that. I am still trying to think of ways how to better package to work around this, but probably what I will go for is for the wheel to always be statically linked, and if they want to install linking to local, that would be controlled by the sdist build.

Thanks for the tip of wheel tags, I will try it out, just as a dirty fix for this specific release while I work on refactoring the build system. I don't quite see in auditwheel how the appropriate tag is specified, I guess the default is dynamic based on the current environment?

@LecrisUT
Copy link
Author

Managed to patch it upstream. Still need to rethink the packaging model. Thanks for the advice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants