Pyo3 0.23.4 broke the river build?

[hoodmane]

error[E0658]: use of unstable library feature `ptr_fn_addr_eq`                  
  -->                                                                           
/root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/pyo3-0.23.4/src/inter
nal_tricks.rs:56:9                                                              
   |                                                                            
56 |         std::ptr::fn_addr_eq(f, g)                                         
   |         ^^^^^^^^^^^^^^^^^^^^                                               
   |                                                                            
   = note: see issue #129322 <https://github.com/rust-lang/rust/issues/129322>  
for more information                                                            
   = help: add `#!` to the crate attributes to enable                           
   = note: this compiler was built on 2024-11-30; consider upgrading it if it is
out of date

https://circleci.com/api/v1.1/project/github/hoodmane/pyodide/101450/output/106/0?file=true&allocation-id=67853a4609d7764763a89cc2-0-build%2FABCDEFGH

[agriyakhetarpal]

cc: the recipe maintainer, @MaxHalford, for visibility

@AdilZouitine, I remember you were working on the Rust part of the River codebase last month, at the time of our NumPy v2 update. I hope it is okay to ping you here in case you'll be able to help :)

[hoodmane]

Per the error message the code that's failing is in pyo3. Presumably we just have to update the rust compiler though:

this compiler was built on 2024-11-30; consider upgrading it if it is out of date

[agriyakhetarpal]

Ah, didn't notice that – sorry for the noise!

[hoodmane]

The commit that introduced the problem is:
PyO3/pyo3#4816
It requires this commit to work:
rust-lang/rust#133678
So we need a nightly more recent than December 1st 2024.

[hoodmane]

I think the best thing would be to pin pyo3 < 0.24.4 for now.