Transport class, is it worth while ?

[janiversen]

I have just been through the first pass of simplifying the client, by removing the extra object (ModbusClientProtocol) creates with a connection, that made me think.

Would it be a good idea to make a "transport" package, that contains:

• TransportBase, everything common for all types of transport and sync/async, like e.g. data handling and reconnect
• TransportAsync, TransportSync, everything common for async / version transport (not I lot I think, apart from the "async" keyword)
• TransportTcp, Tls, Udp and Serial, everything depending on the actual type (like e.g. the create_protocol)

The transport should be made so that it can be used directly by both our client and our server (including REPL).

@dhoomakethu I think to have read somewhere a discussion about making something similar a long time ago, can you share some information ?

@alexrudd2 this would be the time to make something type safe an robust (the current client implementation(s) is a mess of methods, no blame on anybody, it is simply code that have grown over many years).

I hope both of you and anybody will join in with comments, ideas...or scare me from starting :-)

[alexrudd2]

This sounds good in theory, but is too difficult for my current understanding. o_0

[dhoomakethu]

Yes, we at one time thought of making things better and cleaner but I am not able to find that issue any more. I like the Idea though.