Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More informative initial_guess in BudgetOptimizer #876

Open
AlfredoJF opened this issue Jul 26, 2024 · 2 comments
Open

More informative initial_guess in BudgetOptimizer #876

AlfredoJF opened this issue Jul 26, 2024 · 2 comments
Labels

Comments

@AlfredoJF
Copy link

Just wondering the reasoning behind initial_guessto be set flat across all channels.

initial_guess = np.ones(num_channels) * total_budget / num_channels

Shouldn't be more helpful and informative to the optimizer to start with a historical share?

initial_guess = (self.X[self.channel_columns].sum() /
                 self.X[self.channel_columns].sum().sum())
                 .values * total_budget
@AlfredoJF AlfredoJF changed the title More informative initial_guess in BudgetOptimizer` More informative initial_guess in BudgetOptimizer Jul 26, 2024
@wd60622 wd60622 added the MMM label Jul 26, 2024
@cetagostini
Copy link
Contributor

cetagostini commented Jul 26, 2024

Hey @AlfredoJF

This is actually a very good idea, I'll added to the plans. Meantime, I'll be very happy if you can open a PR and move forward this implementation!

Let me know if, you would like to. I can give you a hand 🤚

@cetagostini cetagostini added the good first issue Good for newcomers label Jul 26, 2024
@AlfredoJF
Copy link
Author

Hey @cetagostini

Yeah sounds good, I'll try to get it done this week.

What do you think, should this replace the initial_guess array or have it as an option in allocate_budget similar to custom_constraints logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants