New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line should be an assert or type: ignore, not an if-statement #492

Closed

ricardoV94 opened this issue Jan 18, 2024 · 1 comment

Labels

good first issue ModelBuilder

Contributor

ricardoV94 commented Jan 18, 2024 •

edited

Loading

pymc-marketing/pymc_marketing/model_builder.py

Lines 474 to 477 in c5d72ab

    
           if self.model is not None: 
        
               with self.model: 
        
                   sampler_args = {**self.sampler_config, **kwargs} 
        
                   self.idata = pm.sample(**sampler_args)

ricardoV94 added the good first issue label

Contributor

wd60622 commented Jun 13, 2024

Closed with #741

wd60622 closed this as completed

wd60622 added the ModelBuilder label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment