Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite to remove useless Reshape #845

Open
ricardoV94 opened this issue Jun 23, 2024 · 0 comments
Open

Rewrite to remove useless Reshape #845

ricardoV94 opened this issue Jun 23, 2024 · 0 comments

Comments

@ricardoV94
Copy link
Member

Description

With static types it is possible to find out cases where we know the reshape is useless at compile time. We should remove it when that's the case.

Sometimes the Reshape may also just be expanding dims, pt.scalar().reshape(1, -1) (which showed up in the use of tensordot in #722), which should also be rewritten, as we have many rewrites that reason about Dimshuffles but not Reshapes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant