Don't customize rewrite names

[ricardoV94]

Rewrites can be optionally included or excluded based on their registered names. However, some of the registered names don't match the name of the rewrite function, which is shown with optimizer_verbose=True

For instance:

import pytensor
import pytensor.tensor as pt

seq = pt.vector("seq")
xs, _ = pytensor.scan(
  lambda s: pt.exp(s),
  sequences = [seq],
)

pytensor.config.optimizer_verbose=True
pytensor.function([seq], xs)

...
rewriting: rewrite push_out_seq_scan replaces for{cpu,scan_fn}.0 of for{cpu,scan_fn}(Subtensor{int64}.0, Subtensor{:int64:}.0, Subtensor{int64}.0) with Elemwise{exp,no_inplace}.0 of Elemwise{exp,no_inplace}(Subtensor{:int64:}.0)
...

You would think you can disable it, by excluding push_out_seq_scan, but that does not work

from pytensor.compile.mode import get_mode

pytensor.function([seq], xs, mode=get_mode(None).excluding("push_out_seq_scan"))  

...
rewriting: rewrite push_out_seq_scan replaces for{cpu,scan_fn}.0 of for{cpu,scan_fn}(Subtensor{int64}.0, Subtensor{:int64:}.0, Subtensor{int64}.0) with Elemwise{exp,no_inplace}.0 of Elemwise{exp,no_inplace}(Subtensor{:int64:}.0)
...

Still there. Because it's actually registered with the name scan_pushout_seqs_ops:

pytensor/pytensor/scan/rewriting.py

Line 2486 in 277559b

"scan_pushout_seqs_ops",

pytensor.function([seq], xs, mode=get_mode(None).excluding("scan_pushout_seqs_ops"))  

Now it's excluded!

We should register the rewrites with the same name of the function that is shown in the debug (easy) or find a way to show the registration name instead (possibly harder?).

[michaelraczycki]

I'd like to help with that

[ricardoV94]

That'd be great!