You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #1178 we rewrite batched dots that are just multiplication away, but left core dots the same due to use of BLAS operations for those (whether they are worth it or not is a question on its own). But there is one case that is definitely not worth it: scalar multiplication.
The following graph should definitely be simplified:
We should also consider the remaining cases that are just multiplication, specially in non-default backends where the BLAS question is completely irrelevant. Even in the C-backend I saw many cases where it was faster without BLAS (but some where it was slower :( )
Description
In #1178 we rewrite batched dots that are just multiplication away, but left core dots the same due to use of BLAS operations for those (whether they are worth it or not is a question on its own). But there is one case that is definitely not worth it: scalar multiplication.
The following graph should definitely be simplified:
Or without BLAS stuff
Those should just be mul because that can be fused with other Elemwise operations (and calling BLAS for it is the silliest thing ever)
The text was updated successfully, but these errors were encountered: