-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand logging test cases for sample_prior_predictive and add return type overloads #7707
Merged
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7707 +/- ##
=======================================
Coverage 92.67% 92.67%
=======================================
Files 107 107
Lines 18319 18323 +4
=======================================
+ Hits 16977 16981 +4
Misses 1342 1342
|
Happy to split the overload addition to a separate PR if it's preferrable |
ricardoV94
reviewed
Mar 3, 2025
ricardoV94
reviewed
Mar 3, 2025
ricardoV94
reviewed
Mar 3, 2025
ricardoV94
approved these changes
Mar 3, 2025
Thanks @nataziel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expand logging test cases for sample_prior_predictive & add return type overloads
Description
Expanded logging test cases to clarify expected behaviour/purpose of logged message in
sample_prior_predictive
Added return type overloads while I'm in there for useability (and to remove a bunch of instances of
assert isinstance(trace, az.InferenceData)
from my own code 😂)Related Issue
pm.sample_prior_predictive
reports it will sample all volatile basic RVs even whenvar_names
is supplied #7703Checklist
Type of change
📚 Documentation preview 📚: https://pymc--7707.org.readthedocs.build/en/7707/