Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise informative error if dictionary is passed as observed of DensityDist #6032

Closed
ricardoV94 opened this issue Aug 6, 2022 · 3 comments
Closed

Raise informative error if dictionary is passed as observed of DensityDist #6032

ricardoV94 opened this issue Aug 6, 2022 · 3 comments
Labels
beginner friendly enhancements

Comments

@ricardoV94
Copy link
Member

This is a common source of confusion in people switching from V3 to V4. We could print an informative message when users try to do it.
@juanitorduz
Copy link
Contributor

juanitorduz commented Aug 31, 2022 •
edited
Loading

It is still a confusion for me (I had to use pm.Potential) 🙈 , what is the correct type for the observed parameter? (I can add a fix accordingly)

@ricardoV94
Copy link
Member Author

ricardoV94 commented Aug 31, 2022 •
edited
Loading

observed should be exactly the same as for other distributions (pd.Series, np.array, pm.Data). Dictionaries are no longer a thing.

@ricardoV94 ricardoV94 mentioned this issue Sep 10, 2022
Closed
@symeneses symeneses mentioned this issue Nov 12, 2022
Merged
@michaelosthege
Copy link
Member

Closed by #6292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
beginner friendly enhancements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@michaelosthege @juanitorduz @ricardoV94