Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[primer] Flaky results from inference differences #8790

Closed
jacobtylerwalls opened this issue Jun 22, 2023 · 4 comments
Closed

[primer] Flaky results from inference differences #8790

jacobtylerwalls opened this issue Jun 22, 2023 · 4 comments
Labels
Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning primer

Comments

@jacobtylerwalls
Copy link
Member

See #8758 (comment) for a recent example of subtle differences in messages comparing unequal and causing noisy, irrelevant primer output.

Messages like invalid-name and deprecated-typing-alias seem to be the worst offenders.

@jacobtylerwalls jacobtylerwalls added Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning primer labels Jun 22, 2023
@jacobtylerwalls
Copy link
Member Author

I'll reopen if I see this again.

@jacobtylerwalls jacobtylerwalls closed this as not planned Won't fix, can't repro, duplicate, stale Jul 3, 2023
@Pierre-Sassoulas
Copy link
Member

I had a long term plan to make the primer prettier by showing only what really changed, but my work branch is basically impossible to rebase at this point. Should have concluded the MR when I had the chance. It's not super simple to do, you need to decide if a message is a new message or a modified message from information that is not very stable. Basically some fields are more important than others. Also the commit is not set for the primed repo, which make this a shaky ground to decide from the json we have. And there's of course a lot of markdown output fine tunning to do.

@jacobtylerwalls jacobtylerwalls changed the title [primer] Flaky results from subtle inference differences [primer] Flaky results from inference differences Jul 6, 2023
@jacobtylerwalls
Copy link
Member Author

Still happening, not particularly subtle.

See recent runs like #8824 (comment), on a PR only touching pyreverse 😭 .

@jacobtylerwalls
Copy link
Member Author

I have reason to believe #8872 made this significantly more deterministic. Will reopen if I see it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs investigation 🔬 A bug or crash where it's not immediately obvious what is happenning primer
Projects
None yet
Development

No branches or pull requests

2 participants