Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move away from imp #594

Closed
PCManticore opened this issue Jul 15, 2018 · 4 comments · Fixed by #857
Closed

Move away from imp #594

PCManticore opened this issue Jul 15, 2018 · 4 comments · Fixed by #857

Comments

@PCManticore
Copy link
Contributor

Now that we only support Python 3, we should move away from imp to importlib.

Check https://bugs.python.org/issue34056 and #593 (comment).
@sushobhit27
Copy link

@PCManticore can I work on this as this seems to be simple find replace issue.

@PCManticore
Copy link
Contributor Author

@sushobhit27 Please do!

@PCManticore PCManticore mentioned this issue Jul 6, 2019
Closed
@degustaf degustaf mentioned this issue Jul 24, 2019
Closed
2 tasks
@pkolbus
Copy link
Contributor

pkolbus commented Jul 28, 2020

I'm running into the DeprecationWarning as well, as enabling this warning is recommended by the Python 3.9 release notes; PEP 594 indicates a desire to remove imp in 3.10 which is now starting development. @degustaf has made excellent headway on this in #686 but this work has stalled.

@PCManticore @degustaf any objection if I take this (and #681) over?

@degustaf
Copy link
Contributor

@pkolbus I have no issue with you taking this over. I have been busy on other things.

@pkolbus pkolbus mentioned this issue Nov 22, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency on imp. pkolbus/astroid
4 participants
@PCManticore @degustaf @pkolbus @sushobhit27