Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of force_to_top for isort #5675

Closed
jrbourbeau opened this issue Aug 4, 2021 · 1 comment
Closed

Use of force_to_top for isort #5675

jrbourbeau opened this issue Aug 4, 2021 · 1 comment

Comments

@jrbourbeau
Copy link
Contributor

In dask/distributed#5170, @fjetter pointed out that distributed was incorrectly using force_to_top in our isort configuration (we should have been using float_to_top instead). Just a minor point, but since xarrays isort configuration influenced what we did over in dask and distributed, I thought it was worth letting the Xarray devs know about it

xarray/setup.cfg

Line 164 in 8f5b4a1

force_to_top = true

@max-sixty
Copy link
Collaborator

Thanks @jrbourbeau , agree.

Would take a PR if anyone is up for a short one...

@max-sixty max-sixty mentioned this issue Aug 12, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@max-sixty @jrbourbeau