Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate has undefined name 'dim' #2833

Closed
max-sixty opened this issue Mar 20, 2019 · 2 comments
Closed

Integrate has undefined name 'dim' #2833

max-sixty opened this issue Mar 20, 2019 · 2 comments

Comments

@max-sixty
Copy link
Collaborator

https://github.com/pydata/xarray/blob/master/xarray/core/dataset.py#L4085

Should that be called coord or dim? Currently there's a variable that's undefined:

            raise ValueError('Coordinate {} does not exist.'.format(dim))

I would have made a quick fix but not sure the correct name
@shoyer
Copy link
Member

shoyer commented Mar 22, 2019

I think it should be coord. Also we should add a unit test :)

@max-sixty max-sixty mentioned this issue Mar 23, 2019
Merged
@max-sixty max-sixty mentioned this issue Jun 10, 2019
Merged
2 tasks
@max-sixty
Copy link
Collaborator Author

Closed by #3010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shoyer @max-sixty