You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can you open a new issue to remind us to come back to this (question about marking strings as translatable if they're generated within JavaScript) please?
In 1454, I added a banner type landmark to the pink version warning banner and labeled it with the string "Version warning" (in pydata-sphinx-theme.js line 473).
The landmark label is not visible; it's only exposed by assistive technology, such as screen readers. But like all user-facing strings, the "Version warning" label needs to be added to the set of translatable strings, but I don't know how to do that in JavaScript.
The text was updated successfully, but these errors were encountered:
Originally posted by @drammock in #1454 (comment)
Summary
In 1454, I added a banner type landmark to the pink version warning banner and labeled it with the string "Version warning" (in pydata-sphinx-theme.js line 473).
The landmark label is not visible; it's only exposed by assistive technology, such as screen readers. But like all user-facing strings, the "Version warning" label needs to be added to the set of translatable strings, but I don't know how to do that in JavaScript.
The text was updated successfully, but these errors were encountered: