Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a configurable template for the centre of the footer #1429

Closed
Cadair opened this issue Sep 6, 2023 · 1 comment · Fixed by #1432
Closed

Add a configurable template for the centre of the footer #1429

Cadair opened this issue Sep 6, 2023 · 1 comment · Fixed by #1432

Comments

@Cadair
Copy link
Contributor

Cadair commented Sep 6, 2023 •
edited
Loading

Hello,

In the process of migrating sunpy's sphinx theme to be based on the pydata theme I have modified the footer to take a customisable template for the centre of the footer, and some css tweaks to lay them out using flexbox.

Would this be something that you would be interested me contributing upstream?
@drammock
Copy link
Collaborator

drammock commented Sep 6, 2023 •
edited
Loading

SGTM. I've considered it before but didn't bother because (1) we didn't need it for our own docs, and (2) nobody had asked for it yet. PR welcome!

@Cadair Cadair mentioned this issue Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the ability to add a center section to the footer Cadair/pydata-sphinx-theme
2 participants
@Cadair @drammock