Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch from flak8 to ruff #1270

Closed
12rambau opened this issue Mar 27, 2023 · 0 comments · Fixed by #1271
Closed

switch from flak8 to ruff #1270

12rambau opened this issue Mar 27, 2023 · 0 comments · Fixed by #1271
Labels
kind: maintenance Improving maintainability and reducing technical debt

Comments

@12rambau
Copy link
Collaborator

12rambau commented Mar 27, 2023 •
edited
Loading 

          I wonder if we should swap to ruff instead https://github.com/charliermarsh/ruff ?

I have been using it in other projects and I definitely appreciate the speed improvements (plus it is basically on par with flake8)

Originally posted by @trallard in #1268 (comment)

I think using ruff + prettier we could also get rid of the standard pre-commits that redudant with these linters (whitespaces, trailing, etc...)
@12rambau 12rambau mentioned this issue Mar 28, 2023
Merged
@12rambau 12rambau added the kind: maintenance Improving maintainability and reducing technical debt label Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: maintenance Improving maintainability and reducing technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: spring cleaning 12rambau/pydata-sphinx-theme
1 participant
@12rambau