Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File man/ansi2html.1 missing in ansi2html 1.6.0 PyPI tarballs #124

Closed
hartwork opened this issue Nov 18, 2020 · 1 comment · Fixed by #173
Closed

File man/ansi2html.1 missing in ansi2html 1.6.0 PyPI tarballs #124

hartwork opened this issue Nov 18, 2020 · 1 comment · Fixed by #173
Labels
enhancement This issue/PR relates to a feature request. packaging Packaging category
Milestone

Comments

@hartwork
Copy link
Collaborator

hartwork commented Nov 18, 2020

Hi!

Release 1.5.2 included a rendered man page at man/ansi2html.1. Release 1.6.0 misses that file so that Linux packaging now needs to install AsciiDoc and render the man page.

# find -name \*.1\*
./ansi2html-1.5.2/man/ansi2html.1
./ansi2html-1.5.2/man/ansi2html.1.txt
./ansi2html-1.6.0/man/ansi2html.1.txt

My guess is that step make man/ansi2html.1 was forgotten before setup.py sdist during release creation. Are there plans to bring the rendered man page back?

Thanks and best, Sebastian

@hartwork
Copy link
Collaborator Author

hartwork commented Feb 3, 2022

Seems like Manifest.in still includes the file…

include man/ansi2html.1

…but nothing in tox.ini

ansi2html/tox.ini

Lines 47 to 53 in 0165811

commands =
rm -rfv {toxinidir}/dist/
python -m build \
--outdir {toxinidir}/dist/ \
{toxinidir}
# metadata validation
sh -c "python -m twine check {toxinidir}/dist/*"

… would build the file while releasing.

@ssbarnea would you consider this a bug or a feature?

@hartwork hartwork added the needs-info This issue/PR needs more information to progress. label Feb 3, 2022
@hartwork hartwork added this to the 1.7.1 milestone May 15, 2022
@hartwork hartwork added packaging Packaging category enhancement This issue/PR relates to a feature request. and removed needs-info This issue/PR needs more information to progress. labels May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request. packaging Packaging category
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant