More clearly describe the behavior of constant_time.bytes_eq #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
|
Test PASSed. |
reaperhulk
added a commit
that referenced
this pull request
Feb 5, 2014
More clearly describe the behavior of constant_time.bytes_eq
joerichter-stash
pushed a commit
to kiwigrid/cryptography
that referenced
this pull request
Nov 15, 2017
Fix up the assert helpers, subclass form `object` rather than test case, and use parametrization where appropriate. One helper method on the original `TestCase` was the ability to create temporary directories that were cleaned up at the end of the test -- now we use a pytest fixture instead: http://doc.pytest.org/en/latest/tmpdir.html Addresses pyca#340.
joerichter-stash
pushed a commit
to kiwigrid/cryptography
that referenced
this pull request
Nov 15, 2017
* Convert ServerNameCallbackTests to use pytest-style tests As well as pytest-ifying up the tests, remove a few redundant tests and tidy up docstrings as per feedback in pyca#563. Addresses pyca#340. * Remove a stray ':py:obj:' in test docstring * Remove _LoopbackMixin from TestServerNameCallback Per @hynek feedback. This test class only depended on one method, which can be broken out as a separate function anyway -- I'll gradually disassemble the loopback as I pytest-ify other tests. * Re-wrap a few comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.