-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize RSA public keys #1706
Conversation
You can rebase all teh stuff out of this now. |
7529439
to
fbd7334
Compare
3 similar comments
fbd7334
to
57de33c
Compare
fe041e9
to
301997f
Compare
2 similar comments
301997f
to
34d0117
Compare
34d0117
to
3f157e0
Compare
method available on | ||
:class:`~cryptography.hazmat.primitives.asymmetric.rsa.RSAPublicKeyWithSerialization`. | ||
|
||
.. attribute:: SubjectPublicKeyInfo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the best name for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the name used by PyCrypto and Crypto++. Go calls it a "DER-encoded PKIX structure" but if you look in the source code it says "pkixPublicKey reflects a PKIX public key structure. See SubjectPublicKeyInfo in RFC 3280."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Good enough for me.
On Sun, Mar 8, 2015 at 3:12 PM, Paul Kehrer notifications@github.com
wrote:
In docs/hazmat/primitives/asymmetric/serialization.rst
#1706 (comment):@@ -309,6 +309,25 @@ Serialization Formats
encryption. Choose this unless you have explicit legacy compatibility
requirements.+.. class:: PublicFormat
+
- .. versionadded:: 0.8
- An enumeration for public key formats. Used with the
public_bytes
- method available on
- :class:
~cryptography.hazmat.primitives.asymmetric.rsa.RSAPublicKeyWithSerialization
.
- .. attribute:: SubjectPublicKeyInfo
It's the name used by PyCrypto and Crypto++
http://www.cryptopp.com/wiki/Keys_and_Formats#Public_Key_Format. Go
calls it a "DER-encoded PKIX structure" but if you look in the source code
it says "pkixPublicKey reflects a PKIX public key structure. See
SubjectPublicKeyInfo in RFC 3280."—
Reply to this email directly or view it on GitHub
https://github.com/pyca/cryptography/pull/1706/files#r26007907.
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084
Besides those comments this looks fan-dab-tastic |
Outstanding work:
PublicFormat
naming.