Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialize RSA public keys #1706

Merged
merged 2 commits into from
Mar 8, 2015
Merged

Conversation

reaperhulk
Copy link
Member

Outstanding work:

@reaperhulk reaperhulk added this to the Eighth Release milestone Mar 1, 2015
@alex
Copy link
Member

alex commented Mar 1, 2015

You can rebase all teh stuff out of this now.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fbd7334 on reaperhulk:serialize-rsa-public-key into d208417 on pyca:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fbd7334 on reaperhulk:serialize-rsa-public-key into d208417 on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fbd7334 on reaperhulk:serialize-rsa-public-key into d208417 on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling fbd7334 on reaperhulk:serialize-rsa-public-key into d208417 on pyca:master.

@reaperhulk reaperhulk force-pushed the serialize-rsa-public-key branch 3 times, most recently from fe041e9 to 301997f Compare March 2, 2015 14:52
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 301997f on reaperhulk:serialize-rsa-public-key into 741175e on pyca:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 301997f on reaperhulk:serialize-rsa-public-key into 741175e on pyca:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 301997f on reaperhulk:serialize-rsa-public-key into 741175e on pyca:master.

method available on
:class:`~cryptography.hazmat.primitives.asymmetric.rsa.RSAPublicKeyWithSerialization`.

.. attribute:: SubjectPublicKeyInfo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the best name for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the name used by PyCrypto and Crypto++. Go calls it a "DER-encoded PKIX structure" but if you look in the source code it says "pkixPublicKey reflects a PKIX public key structure. See SubjectPublicKeyInfo in RFC 3280."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Good enough for me.

On Sun, Mar 8, 2015 at 3:12 PM, Paul Kehrer notifications@github.com
wrote:

In docs/hazmat/primitives/asymmetric/serialization.rst
#1706 (comment):

@@ -309,6 +309,25 @@ Serialization Formats
encryption. Choose this unless you have explicit legacy compatibility
requirements.

+.. class:: PublicFormat
+

  • .. versionadded:: 0.8
  • An enumeration for public key formats. Used with the public_bytes
  • method available on
  • :class:~cryptography.hazmat.primitives.asymmetric.rsa.RSAPublicKeyWithSerialization.
  • .. attribute:: SubjectPublicKeyInfo

It's the name used by PyCrypto and Crypto++
http://www.cryptopp.com/wiki/Keys_and_Formats#Public_Key_Format. Go
calls it a "DER-encoded PKIX structure" but if you look in the source code
it says "pkixPublicKey reflects a PKIX public key structure. See
SubjectPublicKeyInfo in RFC 3280."


Reply to this email directly or view it on GitHub
https://github.com/pyca/cryptography/pull/1706/files#r26007907.

"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: 125F 5C67 DFE9 4084

@alex
Copy link
Member

alex commented Mar 8, 2015

Besides those comments this looks fan-dab-tastic

alex added a commit that referenced this pull request Mar 8, 2015
@alex alex merged commit 88e7ed6 into pyca:master Mar 8, 2015
@reaperhulk reaperhulk deleted the serialize-rsa-public-key branch March 8, 2015 20:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants