Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Incorrect gradient object from base.modelS1 #259

Closed
BradyPlanden opened this issue Mar 25, 2024 · 0 comments · Fixed by #260
Closed

[Bug]: Incorrect gradient object from base.modelS1 #259

BradyPlanden opened this issue Mar 25, 2024 · 0 comments · Fixed by #260
Assignees
@BradyPlanden
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

3.8 – 3.12

Describe the bug

The reshape of dy within model.simulateS1 currently returns an incorrect gradient object. At the moment, the reshape results in cross polution of the gradient signals.

Steps to reproduce the behaviour

Running any of the gradient based examples with multiple signals showcases this bug quite clearly.

Relevant log output

No response
@BradyPlanden BradyPlanden added the bug Something isn't working label Mar 25, 2024
@BradyPlanden BradyPlanden self-assigned this Mar 25, 2024
@BradyPlanden BradyPlanden mentioned this issue Mar 25, 2024
Merged
14 tasks
@BradyPlanden BradyPlanden linked a pull request Mar 25, 2024 that will close this issue
Fix gradient calculation from model.simulateS1 #260
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BradyPlanden BradyPlanden

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix gradient calculation from model.simulateS1 pybop-team/PyBOP
1 participant
@BradyPlanden