Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BPX support #79

Closed
BradyPlanden opened this issue Oct 31, 2023 · 0 comments · Fixed by #246
Closed

Add BPX support #79

BradyPlanden opened this issue Oct 31, 2023 · 0 comments · Fixed by #246
Labels
enhancement New feature or request priority:high

Comments

@BradyPlanden
Copy link
Member

BradyPlanden commented Oct 31, 2023 •
edited
Loading

Feature description

This issue is for adding BPX support for import/export of parameter sets. Initial thoughts on the API:

To export:

bpx = pybop.BPX(results=results, parameter_set=parameter_set)
bpx.save(file='test_params.json')

To import:

parameter_set = pybop.BPX.import(file='test_params.json')

Motivation

No response

Possible implementation

No response

Additional context

No response
@BradyPlanden BradyPlanden added the enhancement New feature or request label Oct 31, 2023
@NicolaCourtier NicolaCourtier linked a pull request Mar 19, 2024 that will close this issue
Add BPX support #246
Merged
1 task
@NicolaCourtier NicolaCourtier mentioned this issue Mar 19, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority:high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add BPX support pybop-team/PyBOP
1 participant
@BradyPlanden