Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Scheduled Tests Failing (IRPropMin) #216

Closed
BradyPlanden opened this issue Feb 25, 2024 · 1 comment
Closed

[Bug]: Scheduled Tests Failing (IRPropMin) #216

BradyPlanden opened this issue Feb 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@BradyPlanden
Copy link
Member

Python Version

3.8 - 3.10

Describe the bug

Looks like the scheduled tests are failing after merging #139. Incrementing the assertion tolerances in the integration tests seems to have exceeded the IRPropMin's current capabalities. A couple things to try:

  • Add logic for minimum number of iterations within pybop.Optimisation()
  • Extend number of unchanged iterations
  • Open assertion if needed.

Interestingly, the tests are only failing on 3.8 – 3.10.

Steps to reproduce the behaviour

https://github.com/pybop-team/PyBOP/actions/runs/8036885893

Relevant log output

No response

@BradyPlanden BradyPlanden added the bug Something isn't working label Feb 25, 2024
@BradyPlanden
Copy link
Member Author

Closing this issue as #178 appears to have fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant