From 713b427b740698ebeaee26819c11839a6f8ff15f Mon Sep 17 00:00:00 2001 From: "Ralf W. Grosse-Kunstleve" Date: Mon, 28 Oct 2024 10:33:28 -0700 Subject: [PATCH] Replace misleading comment: NVHPC is NOT outdated. --- include/pybind11/detail/internals.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/pybind11/detail/internals.h b/include/pybind11/detail/internals.h index 61b4c1f256..8cf41bccdd 100644 --- a/include/pybind11/detail/internals.h +++ b/include/pybind11/detail/internals.h @@ -325,8 +325,8 @@ struct type_info { # else # error "Unknown combination of MSVC preprocessor macros: PLEASE REVISE THIS CODE." # endif -# elif defined(__NVCOMPILER) // NVHPC (PGI-based, outdated). -# define PYBIND11_BUILD_ABI "" // This was never properly guarded. +# elif defined(__NVCOMPILER) // NVHPC (PGI-based). +# define PYBIND11_BUILD_ABI "" // TODO: What should be here, to prevent UB? # else # error "Unknown platform or compiler: PLEASE REVISE THIS CODE." # endif