diff --git a/CHANGELOG.md b/CHANGELOG.md index 8be17aca65..dde65eed1e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -21,6 +21,7 @@ ## Bug fixes +- Pass the correct dimensional temperature to open circuit potential ([#702](https://github.com/pybamm-team/PyBaMM/pull/702)) - Adds missing temperature dependence in electrolyte and interface submodels ([#698](https://github.com/pybamm-team/PyBaMM/pull/698)) - Fix differentiation of functions that have more than one argument ([#687](https://github.com/pybamm-team/PyBaMM/pull/687)) - Add warning if `ProcessedVariable` is called outside its interpolation range ([#681](https://github.com/pybamm-team/PyBaMM/pull/681)) diff --git a/input/parameters/lithium-ion/anodes/graphite_mcmb2528_Marquis2019/parameters.csv b/input/parameters/lithium-ion/anodes/graphite_mcmb2528_Marquis2019/parameters.csv index 614e516fb1..28a1733cb4 100644 --- a/input/parameters/lithium-ion/anodes/graphite_mcmb2528_Marquis2019/parameters.csv +++ b/input/parameters/lithium-ion/anodes/graphite_mcmb2528_Marquis2019/parameters.csv @@ -4,7 +4,6 @@ Name [units],Value,Reference,Notes # Electrode properties,,, Negative electrode conductivity [S.m-1],100,Scott Moura FastDFN,graphite Maximum concentration in negative electrode [mol.m-3],24983.2619938437,Scott Moura FastDFN, -Negative electrode diffusion coefficient [m2.s-1],3.9E-14,Scott Moura FastDFN, Negative electrode diffusivity [m2.s-1],[function]graphite_mcmb2528_diffusivity_Dualfoil1998,, Negative electrode OCP [V],[function]graphite_mcmb2528_ocp_Dualfoil1998, ,,, diff --git a/input/parameters/lithium-ion/cathodes/lico2_Marquis2019/parameters.csv b/input/parameters/lithium-ion/cathodes/lico2_Marquis2019/parameters.csv index f79e4fc401..99f2b3840b 100644 --- a/input/parameters/lithium-ion/cathodes/lico2_Marquis2019/parameters.csv +++ b/input/parameters/lithium-ion/cathodes/lico2_Marquis2019/parameters.csv @@ -4,7 +4,6 @@ Name [units],Value,Reference,Notes # Electrode properties,,, Positive electrode conductivity [S.m-1],10,Scott Moura FastDFN,lithium cobalt oxide Maximum concentration in positive electrode [mol.m-3],51217.9257309275,Scott Moura FastDFN, -Positive electrode diffusion coefficient [m2.s-1],1E-13,Scott Moura FastDFN, Positive electrode diffusivity [m2.s-1],[function]lico2_diffusivity_Dualfoil1998,, Positive electrode OCP [V],[function]lico2_ocp_Dualfoil1998, ,,, diff --git a/input/parameters/lithium-ion/electrolytes/lipf6_Marquis2019/parameters.csv b/input/parameters/lithium-ion/electrolytes/lipf6_Marquis2019/parameters.csv index d99621a3ac..c77aca897b 100644 --- a/input/parameters/lithium-ion/electrolytes/lipf6_Marquis2019/parameters.csv +++ b/input/parameters/lithium-ion/electrolytes/lipf6_Marquis2019/parameters.csv @@ -4,9 +4,8 @@ Name [units],Value,Reference,Notes # Electrolyte properties,,, Typical electrolyte concentration [mol.m-3],1000,Scott Moura FastDFN, Cation transference number,0.4,Scott Moura FastDFN, -Typical lithium ion diffusivity [m2.s-1],5.34E-10,Scott Moura FastDFN, Electrolyte diffusivity [m2.s-1],[function]electrolyte_diffusivity_Capiglia1999,, -Electrolyte conductivity [S.m-1],[function]electrolyte_conductivity_Capiglia1999,, +Electrolyte conductivity [S.m-1],[function]electrolyte_conductivity_Capiglia1999,, ,,, # Activation energies,,, Reference temperature [K],298.15,25C, diff --git a/pybamm/parameters/standard_parameters_lithium_ion.py b/pybamm/parameters/standard_parameters_lithium_ion.py index e981b597fd..73a9f4b793 100644 --- a/pybamm/parameters/standard_parameters_lithium_ion.py +++ b/pybamm/parameters/standard_parameters_lithium_ion.py @@ -406,13 +406,15 @@ def m_p(T): def U_n(c_s_n, T): "Dimensionless open-circuit potential in the negative electrode" sto = c_s_n - return (U_n_dimensional(sto, T) - U_n_ref) / potential_scale + T_dim = Delta_T * T + T_ref + return (U_n_dimensional(sto, T_dim) - U_n_ref) / potential_scale def U_p(c_s_p, T): "Dimensionless open-circuit potential in the positive electrode" sto = c_s_p - return (U_p_dimensional(sto, T) - U_p_ref) / potential_scale + T_dim = Delta_T * T + T_ref + return (U_p_dimensional(sto, T_dim) - U_p_ref) / potential_scale def dUdT_n(c_s_n):